[Patch] New Device Menu

[Garrett92C]

@ you ROW Pre3 guys

I'm not sure why it won't work on your devices and I'm not sure how to troubleshoot it. I'll look into it though and try to fix it...

[Garrett92C]

Originally Posted by jcmarcos

I already have Sconix' nice Advanced System Menus, and I believe I should uninstall "device menu", keeping all other "advanced system menus" patches, such as "framework", of course.

New Device Menu is compatible with all of Sconix's Advanced Menu patches except Advanced Device Menu of course.

[Garrett92C]

Originally Posted by bigdoby

I would love 2G, 3G and Auto too.
Thanks a lot!

I'll see about adding that in the next update.

[isagar2004]

Originally Posted by Garrett92C

Hmm, where do these lines appear when you notice them? Are the horizontal or vertical?

That's probably just webOS's rendering problems. It has nothing to do with your patch.

Originally Posted by Garrett92C

@ you ROW Pre3 guys

I'm not sure why it won't work on your devices and I'm not sure how to troubleshoot it. I'll look into it though and try to fix it...

It's not a problem with ROW Pre 3's. Works fine on mine.

[Garrett92C]

Originally Posted by isagar2004

That's probably just webOS's rendering problems. It has nothing to do with your patch.

I thought so. I've noticed those rendering issue pretty frequently on my Pre3.

Originally Posted by isagar2004

It's not a problem with ROW Pre 3's. Works fine on mine.

Ok, maybe it's due to Regional Settings? I had one report that changing your Regional Settings to USA fixes this. I'd still like to find a way to avoid having to do this though....

[broncot]

Originally Posted by broncot

I want this! My Pre 3 volume buttons don't work, I'd love a patch to control the volume instead of an app. But when I try to remove Jason's flashlight patch, I get an error.

I ran EPR and was able to install this patch, thanks for adding xwTweak support! Working great on my VZW Pre 3

[mgmft]

Originally Posted by Garrett92C

Ok, maybe it's due to Regional Settings? I had one report that changing your Regional Settings to USA fixes this. I'd still like to find a way to avoid having to do this though....

Just set my ROW Pre3 to USA: That worked! Thus it has to do with the regional settings! OK, uninstalling again now and reset to Germany! If I can help to debug, let me know!

[bigdoby]

it definitely has something to do with Regional Settings. I switched to English and the patch worked. When I switched batch to Italian the menu was gone again.
I can handle English, but would love to have it working in other Regional Settings (Italian ) too, let me know how I can help.

[g7]

The menu also doesn't appear on ROW 2.2.4 (EU pre3).

I do not know if it helps... but there are some topbar patches (for example sconix's advanced ones) that have two versions: one for ROW and one for at&t/vzw. By analizing the patches, I see that the ROW ones are adding lines to every localized strings.json. That may explain the Localization Settings thing, as US doesn't need localized strings.

For reference:
Advanced System Menus - Device menu (ATT/VZW) - 1753 lines:
https://github.com/webos-internals/p...menu-vzw.patch

Adavanced System Menus - Device menu (ROW) - 3284 lines:
https://github.com/webos-internals/p...ice-menu.patch


Anyway, awesome work!
Eugenio

[davidtm]

Just installed on my Sprint FrankenPre 2 running 2.2.4 with no issues (after removing Device Menu Megamix patch).

Thanks!!

[geekpeter]

Originally Posted by g7

The menu also doesn't appear on ROW 2.2.4 (EU pre3).

I do not know if it helps... but there are some topbar patches (for example sconix's advanced ones) that have two versions: one for ROW and one for at&t/vzw. By analizing the patches, I see that the ROW ones are adding lines to every localized strings.json. That may explain the Localization Settings thing, as US doesn't need localized strings.

For reference:
Advanced System Menus - Device menu (ATT/VZW) - 1753 lines:
https://github.com/webos-internals/p...menu-vzw.patch

Adavanced System Menus - Device menu (ROW) - 3284 lines:
https://github.com/webos-internals/p...ice-menu.patch


Anyway, awesome work!
Eugenio

the difference in size is maybe windows/linux new line formatting? or is it something totally different?

i do remember something not quite the same but still weird, a patch wouldnt install as it said 1 of my luna files wasnt the right one, i ended up just resaving the file using linux formatting in internalZ and the patch worked after that.

[Garrett92C]

That helps a lot actually. Thanks!

-- Sent via mobile

[geekpeter]

another query, all looks great after using it for nearly a full day, only thing that doesnt seem to "fit in" imho is the volume tab, there is onyl 3 entries yet they take up rather a large amount of vertical screen estate.

wondered if the words, ringtone/media/system could be replaced for small icons, the slider then sitting direct to the right of those icons, and the %amount on the end (if the % is even needed at all, to me its not important as i get a rough idea form the sliders anyways) of the sliders, so that only 1 compact horizontal line is used instead of 2.

only say this as it looks rather big having the titles/% on 1 line, the slider on another then the dividers on a final one, taking 3 "lines" up, its only 3 entries yet i still get the requirement of sliding it up/down because their taking a huge amount of space up.

again only thought of this when again looking back at dkirkers suggestion of modularity and other devs adding to your work, that particular section is cramped already and would end up huge with more stuffed in it. everything else you have looks nice and compact already tho.

also is the indented horizontal bar on the far bottom of the menus required? i know its small but its more screen space, and looks a bit weird seeing it on your device menu and none of the others if using sconix's boltins, drop calendar or mode switcher menus and their clearly missing the indentations.

....enough nit picking, still love it.

[michel_ng]

Originally Posted by mgmft

Just set my ROW Pre3 to USA: That worked! Thus it has to do with the regional settings! OK, uninstalling again now and reset to Germany! If I can help to debug, let me know!

Solution is pretty simple. On non-english devices (for example german) you need to patch /usr/lib/luna/system/luna-systemui/resources/de/views/devicemenu/devicemenu-scene.html instead of /usr/lib/luna/system/luna-systemui/app/views/devicemenu/devicemenu-scene.html to get device menu working!

[OldSkoolVWLover]

Looks awesome garrett, great work!

Originally Posted by Audemars02

i guess i just meant that if you are already connected to a WiFi network, you dont see an option to turn off. You have to know to tap on the WiFi line that shows the current network. Same for Bluetooth. But i guess this is just me nitpicking.. its fine the way it is, but as I said before, I would like to know my WiFi network i am on regardless of where I am in the menu.

again, great work!

Being able to see wifi and bluetooth device would be awesome (I have way to many BT devices)

[kevets]

Another great addition to my Pre3! Love it!

[namgod]

Nice Patch! ...and it works well. I'm running on a VZPre2. The "Phone " icon is missing, but the blank area selects the phone preferences.

[s3rgei]

Garret, you has raised the quality of the UI.
The operation has nothing to do with the locale settings but with the language.
I hope we can soon put it to work in other languages​​.
Thank you very much for your work.

[DMeister]

Originally Posted by s3rgei

Garret, you has raised the quality of the UI.
The operation has nothing to do with the locale settings but with the language.
I hope we can soon put it to work in other languages​​.
Thank you very much for your work.

True, made some tests and changing only the language in US it works.

[DMeister]

Originally Posted by michel_ng

Solution is pretty simple. On non-english devices (for example german) you need to patch /usr/lib/luna/system/luna-systemui/resources/de/views/devicemenu/devicemenu-scene.html instead of /usr/lib/luna/system/luna-systemui/app/views/devicemenu/devicemenu-scene.html to get device menu working!

In this way should he do a specifically patch for each language?

Bingo. I've replaced in .../resources/it/views... the new files, devicemenu-scene.html and devicemenu-scene.html.webosinternals... created on usr/lib/luna/system/luna-systemui/app/views/devicemenu/ and it works good!