[Patch] Messaging - Advanced New Card per Convo

estockda · 10:37 AM

For webOS 2.1.0 only. Verified by traviscurren (Post #20) to finally work!! :-)

Used the code found on webos-internals.org to create this patch while expanding upon it.

Features:
- A setting in messaging preferences to open conversations in a new window.
- Improved over previous iterations in that notifications will use new window or open new window as needed and opened windows don't force themselves to focus. Great for webOS 2.1's stacks.

Known bugs (I hope to fix these when I have time but it is still worth having even with them):
- When composing a new message or launching from Just Type/Contacts, opens conversation in main messaging window
- When opening from "Buddies" list (GChat, AOL, etc), doesn't select that account to send
- When two or more messages have come in, clicking on the left portion of the dashboard brings up the last person to text's window rather than the message list

This updated patch has been submitted to Preware but not yet released. If coming here from Preware, please use this patch (not the one in Preware) until it's updated. Thanks!

Let me know what you guys think and if there are any issues.

Thanks to JayCanuck for his UnifiedDiffCreator and webOS Internals for all they do!

Note to HPalm: Feel free to implement this feature in future webOS versions. :-)

Croathlete · 02/28/2011, 08:58 AM

Just tried it out. Doesn't work for me. Preferences doesn't open and my convos don't open. Not sure what else I can tell you to help you out...

weedalin · 02/28/2011, 09:09 AM

Yep, this patch completely broke Messaging for me too, even with no other Messaging patches installed.

estockda · 02/28/2011, 10:58 AM

Hrm... perhaps it's because I have a few messaging patches installed that it works.

For messaging, I have "History Chat Balloon Color" and "Timestamps Clean"
If you install those first, does it work?

I'm new to patching... Is there anyone out there with experience on how to find out if patches are conflicting and, further, make them not conflict with each other?

@Croathlete and @weedalin, I take it there was no ipkg error on install? I think that would be the first sign of them conflicting. Also, what version are you running? This patch is only for 2.1.0.

Tonight I'll remove all patches and see if I can get it to work.

weedalin · 11:29 AM

No .ipk install error. Tried it with History Balloon Color, then without anything. Same result. I'll try it with History plus Timestamps later today.

Edit: Nope, History + Timestamps doesn't work either.

Running 2.1.0 on a Verizon Pre Plus.

estockda · 02/28/2011, 11:47 AM

Quote:

Originally Posted by weedalin

No .ipk install error. Tried it with History Balloon Color, then without anything. Same result. I'll try it with History plus Timestamps later today.

Edit: Nope, History + Timestamps doesn't work either.

Running 2.1.0 on a Verizon Pre Plus.

Thanks for verifying. I'll remove all my patches tonight and make sure my messaging app is clean to see what I can find.

I actually need to do this anyway to take a few screenshots so if I can uncover a bug in the process, two birds with only one stone!

Croathlete · 02/28/2011, 12:00 PM

Same here. No previous patches installed and no install errors. Running on a Sprint Pre-, webOS 2.1.

drvon · 02/28/2011, 08:01 PM

Didn't work for me as well, but I will wait cause this is such a cool / needed patch.

estockda · 02/28/2011, 09:46 PM

Ok guys.. I sincerely apologize for the error. I forgot to include the diff from the messaging-prefs.js file. I've updated the original post with the corrected patch file and added a screenshot!

I'll also be re-submitting to Preware.

Croathlete · 02/28/2011, 09:57 PM

Still a no-go. Same behavior as before...Chats don't open up and preferences still don't open.

**mamouton** · 02/28/2011, 10:50 PM

same behavior for me preferences won't open it pops up and goes away quickly

theXfactor2011 · 02/28/2011, 11:23 PM

Same as everyone else. It seems to open preference and messages and then closes right away. I like the thought of this patch and when you get it working I bet it will be a huge hit.

Good luck.

ps.
Sprint pre - Webos 2.1
No Messaging patches

kiukiukiu · 03/01/2011, 12:00 AM

It would be great if someone can write them into Synergy services.

estockda · 03/01/2011, 06:45 AM

Thanks for all the feedback and encouragement!

I pulled the messaging files out of the doctor to be sure I had the original files and didn't accidentally modify one without keeping track (like I did the first time).

When comparing that with what was on my phone, they were identical. Just to be sure I removed any messaging patches and overwrote the messaging files from the doctor onto my phone. Then I applied the updated patch in the OP (the one in Preware hasn't been updated yet... submitted but not yet approved) and it works.... So I'm stumped. I swear it's working on my phone. Even added a new screenshot of the preferences.

Anyone have any ideas?

drvon · 03/01/2011, 08:49 AM

Preware hasn't been updated yet so people will be still downloading yesterday's patch that wasn't working.

estockda · 03/01/2011, 09:06 AM

Quote:

Originally Posted by drvon

Preware hasn't been updated yet so people will be still downloading yesterday's patch that wasn't working.

I can see that happening. Can you verify the patch in the OP is working?

Is there anyone else that has tried?

Hopefully Preware will be updated soon but until then use this patch in the OP.

traviscurren · 03/01/2011, 09:20 AM

Quote:

Originally Posted by estockda

I can see that happening. Can you verify the patch in the OP is working?

Is there anyone else that has tried?

Hopefully Preware will be updated soon but until then use this patch in the OP.

Patch in OP not working for me either. Just tried it now. Sprint Pre- with 2.1.0.

estockda · 03/01/2011, 09:59 AM

Quote:

Originally Posted by traviscurren

Patch in OP not working for me either. Just tried it now. Sprint Pre- with 2.1.0.

I think I figured out what's happening. The new patch is 7.7K but the forums are delivering the old 6.8K patch, for whatever reason, even though it lists the new 7.7K patch. The version of the patch should be 2.1.0-2.

I'm attaching the updated file here and will try to get the OP to be the correct one as well.

estockda · 03/01/2011, 10:03 AM

Quote:

Originally Posted by estockda

I think I figured out what's happening. The new patch is 7.7K but the forums are delivering the old 6.8K patch, for whatever reason, even though it lists the new 7.7K patch. The version of the patch should be 2.1.0-2.

I'm attaching the updated file here and will try to get the OP to be the correct one as well.

I deleted the file in the OP, submitted, re-upped it, and finally submitted again. It finally seems to be working. Sorry for all the trouble and thanks for the feedback!

traviscurren · 03/01/2011, 10:14 AM

Quote:

Originally Posted by estockda

I think I figured out what's happening. The new patch is 7.7K but the forums are delivering the old 6.8K patch, for whatever reason, even though it lists the new 7.7K patch. The version of the patch should be 2.1.0-2.

I'm attaching the updated file here and will try to get the OP to be the correct one as well.

This patch works! Thanks!

02/28/2011, 08:58 AM	#2 (permalink)
Croathlete Member Join Date: Jun 2009 Location: NYC Posts: 158 Likes Received: 0 Thanks: 7 Thanked 45 Times in 17 Posts	Just tried it out. Doesn't work for me. Preferences doesn't open and my convos don't open. Not sure what else I can tell you to help you out...
	Liked by

02/28/2011, 09:09 AM	#3 (permalink)
weedalin Member Join Date: Mar 2010 Posts: 50 Likes Received: 0 Thanks: 4 Thanked 7 Times in 4 Posts	Yep, this patch completely broke Messaging for me too, even with no other Messaging patches installed.
	Liked by

02/28/2011, 10:58 AM	#4 (permalink)
estockda Member Join Date: Jun 2009 Posts: 84 Likes Received: 0 Thanks: 17 Thanked 119 Times in 13 Posts	Hrm... perhaps it's because I have a few messaging patches installed that it works. For messaging, I have "History Chat Balloon Color" and "Timestamps Clean" If you install those first, does it work? I'm new to patching... Is there anyone out there with experience on how to find out if patches are conflicting and, further, make them not conflict with each other? @Croathlete and @weedalin, I take it there was no ipkg error on install? I think that would be the first sign of them conflicting. Also, what version are you running? This patch is only for 2.1.0. Tonight I'll remove all patches and see if I can get it to work.
	Liked by

02/28/2011, 11:15 AM	#5 (permalink)
weedalin Member Join Date: Mar 2010 Posts: 50 Likes Received: 0 Thanks: 4 Thanked 7 Times in 4 Posts	No .ipk install error. Tried it with History Balloon Color, then without anything. Same result. I'll try it with History plus Timestamps later today. Edit: Nope, History + Timestamps doesn't work either. Running 2.1.0 on a Verizon Pre Plus. Last edited by weedalin; 02/28/2011 at 11:29 AM.
	Liked by

02/28/2011, 12:00 PM	#7 (permalink)
Croathlete Member Join Date: Jun 2009 Location: NYC Posts: 158 Likes Received: 0 Thanks: 7 Thanked 45 Times in 17 Posts	Same here. No previous patches installed and no install errors. Running on a Sprint Pre-, webOS 2.1.
	Liked by

02/28/2011, 08:01 PM	#8 (permalink)
drvon Member Join Date: Feb 2010 Posts: 67 Likes Received: 0 Thanks: 8 Thanked 1 Time in 1 Post	Didn't work for me as well, but I will wait cause this is such a cool / needed patch.
	Liked by

02/28/2011, 09:46 PM	#9 (permalink)
estockda Member Join Date: Jun 2009 Posts: 84 Likes Received: 0 Thanks: 17 Thanked 119 Times in 13 Posts	Ok guys.. I sincerely apologize for the error. I forgot to include the diff from the messaging-prefs.js file. I've updated the original post with the corrected patch file and added a screenshot! I'll also be re-submitting to Preware.
	Liked by

02/28/2011, 09:57 PM	#10 (permalink)
Croathlete Member Join Date: Jun 2009 Location: NYC Posts: 158 Likes Received: 0 Thanks: 7 Thanked 45 Times in 17 Posts	Still a no-go. Same behavior as before...Chats don't open up and preferences still don't open.
	Liked by

02/28/2011, 10:50 PM	#11 (permalink)
mamouton Forum Leader Join Date: Jan 2007 Location: Fort Worth, TX Posts: 5,771 Likes Received: 5 Thanks: 796 Thanked 1,165 Times in 801 Posts	same behavior for me preferences won't open it pops up and goes away quickly __________________ My contributions to customizing the Palm Pre. Browser Mega Mix\|Email Mega Mix\|Additional Sync Days\| Disable Various Phone Sounds\|Priority Discard Buttons\| Sign up for SugarSync Get 500MB extra space Sign up for Dropbox Get 250MB extra space
	Liked by

02/28/2011, 11:23 PM	#12 (permalink)
theXfactor2011 Member Join Date: Jun 2010 Location: Philadelphia, PA Posts: 114 Likes Received: 0 Thanks: 13 Thanked 20 Times in 18 Posts	Same as everyone else. It seems to open preference and messages and then closes right away. I like the thought of this patch and when you get it working I bet it will be a huge hit. Good luck. ps. Sprint pre - Webos 2.1 No Messaging patches __________________ Sprint pre -> Motorola Photon 4G
	Liked by

03/01/2011, 12:00 AM	#13 (permalink)
kiukiukiu Member Join Date: Jan 2010 Posts: 181 Likes Received: 4 Thanks: 12 Thanked 19 Times in 17 Posts	It would be great if someone can write them into Synergy services.
	Liked by

03/01/2011, 06:45 AM	#14 (permalink)
estockda Member Join Date: Jun 2009 Posts: 84 Likes Received: 0 Thanks: 17 Thanked 119 Times in 13 Posts	Thanks for all the feedback and encouragement! I pulled the messaging files out of the doctor to be sure I had the original files and didn't accidentally modify one without keeping track (like I did the first time). When comparing that with what was on my phone, they were identical. Just to be sure I removed any messaging patches and overwrote the messaging files from the doctor onto my phone. Then I applied the updated patch in the OP (the one in Preware hasn't been updated yet... submitted but not yet approved) and it works.... So I'm stumped. I swear it's working on my phone. Even added a new screenshot of the preferences. Anyone have any ideas?
	Liked by

03/01/2011, 08:49 AM	#15 (permalink)
drvon Member Join Date: Feb 2010 Posts: 67 Likes Received: 0 Thanks: 8 Thanked 1 Time in 1 Post	Preware hasn't been updated yet so people will be still downloading yesterday's patch that wasn't working.
	Liked by

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode