[Patch]Browser fix for no bookmarks displayed bug in 2.0.1

[Dick99999]

On a Pre 2 / webOS 2.0.1 , bookmarks under preferences are sometimes not displayed and deletion and reordering is not possible. This patch fixes that.

Since I do not completely understand what's happening in the original webOS 2.0.1 code, 'I'd appreciate a few beta testers'. I do understand the code I have added though.

[..deleted the code part..]

===== edit
webOS 2.2.4 version included 99 bookmarks patch.

[ApplePie]

Such a patch was already posted HERE by ashirg.

[Dick99999]

Originally Posted by yitz0550

Such a patch was already posted HERE by ashirg.

That addresses another problem for another webOS version. The patch of this thread addresses an intermittent problem on the Pre 2. This patch is about the preference screen that is used for rearranging and deleting bookmarks using the bookmarks list screen, not the tiles screen.

[palmcrash]

Nice. I've run into this problem twice (had to clear all bookmarks each time to fix), so I'll give it a go if it happens yet again.

[cluefree]

Yes! This worked beautifully for my Verizon Pre Plus meta-doctored to 2.1.0.

[Dick99999]

Glad it worked. I'll post a technical question I have about this patch on this forum too. Anybody?

After a while my Pre 2 displays a blank bookmarks list under browser preferences. That inhibits sorting and deleting bookmarks.
Clearing all bookmarks fixes the behavior, but after a while the bug reappears. In my case after a restore.

I looked at the code and don't completely understand it. The bug must be related to the code below, since a patch I made in there, fixes the bug on my Pre 2.

The part I do not understand is the following:

this.controller.setupWidget('bookmarksList',
		{itemTemplate:'bookmarks/bookmarks-entry',
		 listTemplate:'bookmarks/bookmarks-container',
		 itemsCallback:this._retrieveItemsCallback.bind(this),
		 swipeToDelete:true,
		 reorderable:true});

Question: Since there is not data model specified, how does the controller know which datamodel to use? (It's not the widget within a list widget case). Further down the app is using a variable this.bookmarksModel to populate the datamodel with bookmarkrs info

		this.bookmarksModel.push(item);

Then it finishes by just updating the length info of the list widget.

		this.bookmarksListWidget.mojo.setLength(this.bookmarksModel.length);

Since the code obviously works mosttimes, how is the datamodel passed on?

I know that for widgets within widgets, the embedded widget uses the model of the top widget. But that seems not the case here. And perhaps if population of the data is done by callback one should/could? not specify a datamodel? The code above does not use the controller's callback to populate the datamodel.

[tobeaman]

WOW! Thank you! Thank you! Thank you! I have a Pre 2 on VZW. This was happening on 2.0.1 But I thought it would be corrected in 2.1 but, unfortunately, it did not. Your patch works beautifully, though.

[workerb]

Thank you so much for this patch! I migrated to a Pre2 last weekend and this issue started happening. I tried to clear the cookies, cache, history, and all the bookmarks. I then added them back in one and a time and verified that the bookmark list was still there. I finished re-adding all bookmarks and the list page was working fine - until I closed the browser. Then I was back to square one. Until I found your patch. It worked like a charm - saving me and my sanity.

[Dick99999]

Glad it works well for you as it does for me. It's likely one of the few patches of which the designer does not know why the patch works and the original code does not ......

[Gwidion]

Does it function with Pre3?

[Dick99999]

May be the PRe 3 does not have this issue? Have not tried it yet.

[Gwidion]

It function And yes, the Pre3 has this problem! ;(

[lulilola]

Would it be possible to get the patch to work under
WebOS 2.2.4 ?
My Pre 2 has the bookmarks problem (again) after upgrading to this version.

[Dick99999]

The current version works for 2.2.4 too. I'll submit it. If you know how, you can install the current version.
onto 2.2.4

[jaltman]

I tried to tell that to someone in another thread and linked him back to here, but he didn't understand or figure it out. It works fine in 2.2.4. Until submited use webosqi to install.

Thanks for this patch, I appreciate it.

[eny2002]

Originally Posted by lulilola

Would it be possible to get the patch to work under
WebOS 2.2.4 ?
My Pre 2 has the bookmarks problem (again) after upgrading to this version.

Until the submit is complete you can also just send the file in this thread to your email. And download the attachment from your phone. And Internalz will install it for you

[Dick99999]

The 2.1 version installed OK on 2.2.4 but was not exactly right in referencing the code lines to be modified. The 2.2.4 version has been corrected and now also includes the 99 bookmarks patch done by Pastorrich1 with credits.
Without that increase the fix bug patch does not make sense. Side effect: the original 99 lines patch has to be removed before installing the 2.2.4 version of this patch patch.

[lulilola]

Installation via email attachment worked smoothly
on GSM Pre 2 Webos 2.2.4

The patch is really useful. Thanks!

[sshaka]

Thanks for the patch's new version for webOS 2.2.4!!! \m/ It really works!!!

[crowning73]

Are you guys able to install this patch through Internalz? I'm not, it says "only garbage was found in the patch input"!