[Patch] Per-Contact Call Rejection

jjvcuyler · 05/11/2010, 10:06 PM

This patch will add an option to automatically reject calls on a per-contact basis. Calls can be rejected either by sending them directly to voicemail or by a quick answer and hangup.

**berdinkerdickle** · 05/11/2010, 10:10 PM

This was another feature I was hoping to have when I get my Att Pre.

Thanks so much.

kristoffer10 · 05/11/2010, 11:20 PM

off tha hook!!! you guys come up with some bright ideas, sweet!

**mamouton** · 05/11/2010, 11:25 PM

do you know what patches this conflicts with. I have the sms per contact and elryon's call rejection patch installed do these need to be uninstalled?

jjvcuyler · 05/11/2010, 11:31 PM

This will almost certainly conflict with elryon's call rejection patch, as it has similar functionality, and therefore modifies the same files. If you try this one out, make sure you set calls to be rejected from your "Do Not Answer" contact, as this one will not automatically reject calls from anyone by default.

I've also posted an updated/alternate version of the sms per contact patch which definitely does not conflict with this one.

**mamouton** · 05/11/2010, 11:34 PM

Quote:

Originally Posted by jjvcuyler

This will almost certainly conflict with elryon's call rejection patch, as it has similar functionality, and therefore modifies the same files. If you try this one out, make sure you set calls to be rejected from your "Do Not Answer" contact, as this one will not automatically reject calls from anyone by default.

I've also posted an updated/alternate version of the sms per contact patch which definitely does not conflict with this one.

Where is the update patch?
My error log

patching file usr/palm/applications/com.palm.app.contacts/app/controllers/edit-assistant.js
Unreversed patch detected! Ignore -R? [n]
Apply anyway? [n]
Skipping patch.
2 out of 2 hunks ignored -- saving rejects to file usr/palm/applications/com.palm.app.contacts/app/controllers/edit-assistant.js.rej
patching file usr/palm/applications/com.palm.app.contacts/app/controllers/filepicker-behaviors.js
Unreversed patch detected! Ignore -R? [n]
Apply anyway? [n]
Skipping patch.
2 out of 2 hunks ignored -- saving rejects to file usr/palm/applications/com.palm.app.contacts/app/controllers/filepicker-behaviors.js.rej
patching file usr/palm/applications/com.palm.app.phone/app/models/TelephonyEventListener.js
Hunk #1 FAILED at 715.
1 out of 1 hunk FAILED -- saving rejects to file usr/palm/applications/com.palm.app.phone/app/models/TelephonyEventListener.js.rej

jjvcuyler · 05/11/2010, 11:43 PM

Quote:

Originally Posted by mamouton

Where is the update patch?

It's a few threads below this one. The title is [Patch] SMS Tone per Contact v2 It's also available in Preware.

**mamouton** · 05/12/2010, 12:25 AM

Works perfect. I successfully was able to still block with my google voice number. Great job!

trim81 · 05/12/2010, 01:52 AM

offfffffffff the hook! +1

Banger · 05/17/2010, 07:23 AM

Thanks!!!

rigo · 05/17/2010, 08:52 AM

Thanks! Can the same options be added (straight to VM, pickup/hangup) for unknown/blocked numbers?

mjkjr · 05/17/2010, 09:17 AM

Nice, installing now. Thank you.

Mutt · 05/17/2010, 12:53 PM

Quote:

Originally Posted by rigo

Thanks! Can the same options be added (straight to VM, pickup/hangup) for unknown/blocked numbers?

2nd this. I love how clean the patch is but I still want to be able to ignore unknown & blocked numbers. just tried installing elryon's patch for that w/ no luck.

if anyone figures out how to have this patch & set unknown/blocked, please pass it along

Mutt · 05/17/2010, 01:11 PM

ok, I made an edit to one of elryon's patches by lifting code from one of his other patches. I am NOT a coder but this worked for me before and it appears that it would work here too.

in jjvcuyler's patch in the first post of this thread I changed

Code:

if (contact.ringtoneLoc == "direct2vm") {

to this

Code:

if ( (contact.ringtoneLoc == "direct2vm") || (number === undefined) || (number == null) || (number == "") || (number == "unknown") || (number == "unknown caller") || (number == "blocked caller") ) {

as far as I know, this will add unknown & blocked callers to the direct to voicemail option.

I do not know why undefined gets 3 equal signs but that's how he had it.

peterlemonjello · 05/17/2010, 02:07 PM

How does this patch affect notifications & call logs? Will a call set to auto-hangup or direct2vm display a notification? What will show up in the call log and missed call log?

jjvcuyler · 05/19/2010, 10:51 PM

Quote:

Originally Posted by Mutt

ok, I made an edit to one of elryon's patches by lifting code from one of his other patches. I am NOT a coder but this worked for me before and it appears that it would work here too.

in jjvcuyler's patch in the first post of this thread I changed

Code:

if (contact.ringtoneLoc == "direct2vm") {

to this

Code:

if ( (contact.ringtoneLoc == "direct2vm") || (number === undefined) || (number == null) || (number == "") || (number == "unknown") || (number == "unknown caller") || (number == "blocked caller") ) {

as far as I know, this will add unknown & blocked callers to the direct to voicemail option.

I do not know why undefined gets 3 equal signs but that's how he had it.

I'm working the next version of this patch, which will add this functionality and allow you to make changes in the settings of the phone app. There will be an additional menu that will allow you to reject none/not in contacts/blocked/all, and choose the method.

I'm also exploring the phone app to see if there's a way to stop the phone card from popping up when using auto-hangup.

jjvcuyler · 05/19/2010, 10:52 PM

Quote:

Originally Posted by peterlemonjello

How does this patch affect notifications & call logs? Will a call set to auto-hangup or direct2vm display a notification? What will show up in the call log and missed call log?

Direct to voicemail call will show up as missed calls in the log. Auto-hangup calls will show as 1 second incoming calls in the log.

arzoumanian · 05/20/2010, 02:49 PM

Can't wait for the next version of the patch!
Thanks,
Aaron

pegb856 · 05/23/2010, 07:14 PM

OM Goodness, I'm so excited I found this patch. My Hero had the send to voicemail option and I really missed not having it on my Pre.

Woo Hooo!! Thank you for your hard work.

Freshyz · 05/23/2010, 07:22 PM

Great patch!

If I just create one contact called Blocked Numbers for example and add a bunch of #s in there can I assume it will block all of them?

Submitted to Preware?

05/11/2010, 10:10 PM	#2 (permalink)
berdinkerdickle Tazmorator (Chief Mod) Join Date: Dec 2005 Location: P\|C when the light below is green. Otherwise; I could be just about anywhere. Posts: 10,721 Likes Received: 223 Thanks: 3,116 Thanked 2,773 Times in 1,851 Posts	This was another feature I was hoping to have when I get my Att Pre. Thanks so much.
	Liked by

05/11/2010, 11:20 PM	#3 (permalink)
kristoffer10 Member Join Date: Nov 2009 Posts: 292 Likes Received: 0 Thanks: 46 Thanked 14 Times in 13 Posts	off tha hook!!! you guys come up with some bright ideas, sweet!
	Liked by

05/11/2010, 11:25 PM	#4 (permalink)
mamouton Forum Leader Join Date: Jan 2007 Location: Fort Worth, TX Posts: 5,771 Likes Received: 5 Thanks: 796 Thanked 1,165 Times in 801 Posts	do you know what patches this conflicts with. I have the sms per contact and elryon's call rejection patch installed do these need to be uninstalled? __________________ My contributions to customizing the Palm Pre. Browser Mega Mix\|Email Mega Mix\|Additional Sync Days\| Disable Various Phone Sounds\|Priority Discard Buttons\| Sign up for SugarSync Get 500MB extra space Sign up for Dropbox Get 250MB extra space
	Liked by

05/11/2010, 11:31 PM	#5 (permalink)
jjvcuyler Member Join Date: Jun 2009 Posts: 44 Likes Received: 0 Thanks: 1 Thanked 46 Times in 13 Posts	This will almost certainly conflict with elryon's call rejection patch, as it has similar functionality, and therefore modifies the same files. If you try this one out, make sure you set calls to be rejected from your "Do Not Answer" contact, as this one will not automatically reject calls from anyone by default. I've also posted an updated/alternate version of the sms per contact patch which definitely does not conflict with this one.
	Liked by

05/12/2010, 12:25 AM	#8 (permalink)
mamouton Forum Leader Join Date: Jan 2007 Location: Fort Worth, TX Posts: 5,771 Likes Received: 5 Thanks: 796 Thanked 1,165 Times in 801 Posts	Works perfect. I successfully was able to still block with my google voice number. Great job! __________________ My contributions to customizing the Palm Pre. Browser Mega Mix\|Email Mega Mix\|Additional Sync Days\| Disable Various Phone Sounds\|Priority Discard Buttons\| Sign up for SugarSync Get 500MB extra space Sign up for Dropbox Get 250MB extra space
	Liked by

05/12/2010, 01:52 AM	#9 (permalink)
trim81 Member Join Date: Jul 2005 Location: 626, Los Angeles Posts: 2,726 Likes Received: 0 Thanks: 381 Thanked 197 Times in 129 Posts	offfffffffff the hook! +1
	Liked by

05/17/2010, 07:23 AM	#10 (permalink)
Banger Member Join Date: Apr 2009 Posts: 500 Likes Received: 0 Thanks: 132 Thanked 57 Times in 36 Posts	Thanks!!!
	Liked by

05/17/2010, 08:52 AM	#11 (permalink)
rigo Member Join Date: Mar 2005 Posts: 143 Likes Received: 0 Thanks: 5 Thanked 2 Times in 2 Posts	Thanks! Can the same options be added (straight to VM, pickup/hangup) for unknown/blocked numbers?
	Liked by

05/17/2010, 09:17 AM	#12 (permalink)
mjkjr Member Join Date: Dec 2009 Location: Kansas City Missouri Posts: 1,045 Likes Received: 3 Thanks: 1,197 Thanked 259 Times in 200 Posts	Nice, installing now. Thank you.
	Liked by

05/17/2010, 01:11 PM	#14 (permalink)
Mutt Member Join Date: Jun 2009 Posts: 29 Likes Received: 1 Thanks: 1 Thanked 1 Time in 1 Post	ok, I made an edit to one of elryon's patches by lifting code from one of his other patches. I am NOT a coder but this worked for me before and it appears that it would work here too. in jjvcuyler's patch in the first post of this thread I changed Code: if (contact.ringtoneLoc == "direct2vm") { to this Code: if ( (contact.ringtoneLoc == "direct2vm") \|\| (number === undefined) \|\| (number == null) \|\| (number == "") \|\| (number == "unknown") \|\| (number == "unknown caller") \|\| (number == "blocked caller") ) { as far as I know, this will add unknown & blocked callers to the direct to voicemail option. I do not know why undefined gets 3 equal signs but that's how he had it.
	Liked by

05/17/2010, 02:07 PM	#15 (permalink)
peterlemonjello Member Join Date: Jul 2006 Posts: 1,505 Likes Received: 60 Thanks: 150 Thanked 136 Times in 103 Posts	How does this patch affect notifications & call logs? Will a call set to auto-hangup or direct2vm display a notification? What will show up in the call log and missed call log?
	Liked by

05/20/2010, 02:49 PM	#18 (permalink)
arzoumanian Member Join Date: Oct 2009 Posts: 1 Likes Received: 0 Thanks: 1 Thanked 0 Times in 0 Posts	Can't wait for the next version of the patch! Thanks, Aaron
	Liked by

05/23/2010, 07:14 PM	#19 (permalink)
pegb856 Member Join Date: Dec 2009 Location: Indiana Posts: 79 Likes Received: 0 Thanks: 22 Thanked 0 Times in 0 Posts	OM Goodness, I'm so excited I found this patch. My Hero had the send to voicemail option and I really missed not having it on my Pre. Woo Hooo!! Thank you for your hard work.
	Liked by

05/23/2010, 07:22 PM	#20 (permalink)
Freshyz Member Join Date: Jun 2009 Location: Utah Posts: 926 Likes Received: 1 Thanks: 211 Thanked 114 Times in 92 Posts	Great patch! If I just create one contact called Blocked Numbers for example and add a bunch of #s in there can I assume it will block all of them? Submitted to Preware?
	Liked by

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode