[Patch] Swipe to Delete in Contacts

[IMGrant]

Here is a patch that enables the familiar swipe to delete gesture in the list of contacts in the same said app. You can use webOS Quick Install to apply it.

I basically looked how it was done by Palm in the contact details or edit view, I've tested it on the emulator with Google and Facebook contact accounts, but would appreciate some more testing before I submit it as a patch for Preware, please try it out and let me know how it works.

[rinkeedink]

Thanks for making this!

Here's a couple of things I noticed.

1. When I installed via WebOS quickinstall, it reset my phone..is this typical?
2. My theme wallpaper disappeared and I had a black screen. I easily reinstalled the wallpaper theme.
3. The delete works fine, and the confirm step is there as in the usual delete method.
4. Can you make the delete command be an UNDO in the edit menu? Sometimes I hit the wrong contact because the contact entries line is a bit narrow and the deletion cannot be undone.

Otherwise..thanks!! Nice work. :-)

[2sslow]

Originally Posted by rinkeedink

Thanks for making this!

Here's a couple of things I noticed.

1. When I installed via WebOS quickinstall, it reset my phone..is this typical?
2. My theme wallpaper disappeared and I had a black screen. I easily reinstalled the wallpaper theme.
3. The delete works fine, and the confirm step is there as in the usual delete method.
4. Can you make the delete command be an UNDO in the edit menu? Sometimes I hit the wrong contact because the contact entries line is a bit narrow and the deletion cannot be undone.

Otherwise..thanks!! Nice work. :-)

Let me say its about time this patch was created! thanks IMGrant.

1. thats completely normal in WOSQI
2. must be some conflicting issue with your theme. Please post what theme you are using.
4. I dont think thats possible, once you delete anything on the Pre its Gone so be careful. lol

[IMGrant]

Originally Posted by rinkeedink

1. When I installed via WebOS quickinstall, it reset my phone..is this typical?

That's normal, it's just restarting the UI, you'd have to restart manually when using Preware to see the changes.

Originally Posted by rinkeedink

2. My theme wallpaper disappeared and I had a black screen. I easily reinstalled the wallpaper theme.

Not sure what caused that, I have changed my wallpaper but not used themes. I don't think it's my patch but it might be WOSQI - had you only just applied the theme/wallpaper?

Originally Posted by rinkeedink

4. Can you make the delete command be an UNDO in the edit menu? Sometimes I hit the wrong contact because the contact entries line is a bit narrow and the deletion cannot be undone.

Not exactly sure what you mean by the delete command in the edit menu, but as 2sslow said, it would be difficult, a hefty re-write of the Contacts app I think, as there is no native undo to make use of like there is delete in this case, for example.
That said, can you explain how you accidentally deleted a contact? I would've thought you'd always get a confirm prompt, either in the form of the delete and cancel buttons that are underneath a row when you swipe it away to delete, or as a popup alert.

[knickrox13]

works great! Now, just add it to a feed for the rest of the gang here.

[rinkeedink]

Originally Posted by IMGrant

That's normal, it's just restarting the UI, you'd have to restart manually when using Preware to see the changes.

Not sure what caused that, I have changed my wallpaper but not used themes. I don't think it's my patch but it might be WOSQI - had you only just applied the theme/wallpaper?

Not exactly sure what you mean by the delete command in the edit menu, but as 2sslow said, it would be difficult, a hefty re-write of the Contacts app I think, as there is no native undo to make use of like there is delete in this case, for example.
That said, can you explain how you accidentally deleted a contact? I would've thought you'd always get a confirm prompt, either in the form of the delete and cancel buttons that are underneath a row when you swipe it away to delete, or as a popup alert.

First, thanks again for doing this awesome patch!!

I've had the Dolphins theme installed for a few months, and I have dozens of other patches installed, which have not caused that removal of the wallpaper. All the other theme elements [app icons, etc.] throughout the GUI remained intact.

Sorry for any funky wording regarding the UNDO question. I just was wondering if it were possible to patch an UNDO for a delete command into say, the Edit menu copy/paste drop down list for the Contacts program. Sounds like a major hurdle if possible, and not a patch of making existing coding accessible.

Yes, I boneheadedly deleted a contact I didn't intend, even with a confirm prompt.

[chase1980]

Thanks!!!!!! I was just thinking how nice this would be the other day. Works great so far.

[IMGrant]

Originally Posted by rinkeedink

Yes, I boneheadedly deleted a contact I didn't intend, even with a confirm prompt.

lol

Excellent news, thanks for the feedback everyone. I'll submit the patch for inclusion in the Preware feed shortly.

[spud101]

What's the impact "sync" wise?
Does it also delete Google & Exchange Contact?
And what about a Facebook, LinkedIN & Yahoo contacts?

[IMGrant]

Originally Posted by spud101

What's the impact "sync" wise?
Does it also delete Google & Exchange Contact?
And what about a Facebook, LinkedIN & Yahoo contacts?

What do you mean, impact sync-wise? I can't see that there would be any impact to the sync mechanism. IIRC, webOS syncs the contacts on a schedule, something like every 15 minutes. Might be wrong on that tho.

It's exactly the same ,mechanism behind the scenes as going into the contact's details/edit view and choosing 'delete' from the app menu - you can delete Google, Exchange and Palm Profile contacts, but not Facebook. I don't have LinkedIn or Yahoo so haven't tested (would appreciate if someone could), but I assume you can't delete LinkedIn in the same way as Facebook, but you can delete Yahoo.

[IMGrant]

Just got round to trying my own patch (!) on my actual Pre, rather than the emulator, and I have to say the performance is disappointing - you can do the whole swipe before the Pre starts animating the list item! At least it still works as intended, but I sure hope the webOS UI speeds up some soon...

[rege0039]

I can't install this. With PreWare I get told IPKG error and with Quick Install it reports

4 out of 4 hunks failed. saving rejects to file

[IMGrant]

Originally Posted by rege0039

I can't install this. With PreWare I get told IPKG error and with Quick Install it reports

4 out of 4 hunks failed. saving rejects to file

With what version of webOS? And do you have any other Contacts patches installed?

[rege0039]

Webos 1.31 on GSM.

My contacts have now gone blank, they are there in messaging but if I start the contacts apps I just get a blank screen.

I don't have any other contact patches installed.

Any help with blank screen ?

[IMGrant]

Originally Posted by rege0039

Webos 1.31 on GSM.

My contacts have now gone blank, they are there in messaging but if I start the contacts apps I just get a blank screen.

I don't have any other contact patches installed.

Any help with blank screen ?

Even though it failed to install? That is odd. Have you tried rebooting since trying to install?
Also try Emergency Patch Recovery.

[rege0039]

Yes I have re-booted.

Won't emergency patch recovery delete all my patches (I have 40 or so installed !) ?

Thanks

[IMGrant]

Originally Posted by rege0039

Yes I have re-booted.

Won't emergency patch recovery delete all my patches (I have 40 or so installed !) ?

Thanks

Yes it will. It's a bit of a last resort, but from a developer's point of view, it is really hard to debug something remotely when you don't know what else is going on. I test my patches on the emulator by themselves and on my Pre, which has other patches installed too, but probably not the same ones, you know.

Anyway, another option is to manually restore the original version of the file, which is at /usr/palm/applications/com.palm.app.contacts/app/controllers/list-assistant.js

When the patch is installed, the previous/original version of the file is usually backed up to list-assistant.js.webosinternals.orig - check if that file is on your Pre and copy it over list-assistant.js. You'll need to remount / with write access, or you can use WebOS Quick Install to receive the file and then send it back to the device - WOSQI takes care of writing permissions as it needs as far as I know.

[rege0039]

I have a list.assitant.js.orig (0 bytes) and a list.assistant.js.webosinternals.orig (8Kb)

I presume I use the latter ? Not sure how to receive with WebOS Quick Install, any guidelines anywhere ?

thanks for help and quick response

[IMGrant]

Originally Posted by rege0039

I have a list.assitant.js.orig (0 bytes) and a list.assistant.js.webosinternals.orig (8Kb)

I presume I use the latter ? Not sure how to receive with WebOS Quick Install, any guidelines anywhere ?

thanks for help and quick response

Ah, something has gone very wrong there then. list-assistant.js should be 21.2 KB. I have attached the original version of the file (from webOS 1.3.1).

To send files via WOSQI, choose 'Send File' from the Tools menu. It will ask you for the destination path to upload the file to (/usr/palm/applications/com.palm.app.contacts/app/controllers/) and give you a browse button to select the local file.

[rege0039]

Every time I try to send the file it seems to be OK, but when I look with internalz on the device it says the file length for list-assistant.js is 0kb - even though I know it is 22Kb !

Still got a blank contacts screen !

Ahaha

But thanks for your help, your fast responses are amazing !