[autopatch] Browser Multi-Patch

[woody88]

I tried to use the shift key (orange) button to go page up, but it does not seem to be working. All other shortcuts appear to work right. Does anybody have any idea what's going on for my issue possibly? Thx in advance.

[dwhitman]

Originally Posted by woody88

I tried to use the shift key (orange) button to go page up, but it does not seem to be working. All other shortcuts appear to work right. Does anybody have any idea what's going on for my issue possibly? Thx in advance.

As I read the thread above, the keycode sent by the shift key changed in webOS 1.2 which broke that small piece of the multi-mod patch (it's looking for a keycode that the shift key no longer produces).

Reading between the lines, it looks like the author hard-coded the old numeric code for shift key, rather than use a defined constant ("Mojo.Char.shift"). Using the constant would have made the patch immune to the keycode change; as it is, the patch needs a small correction here and there.

It seems like a fairly simple fix, but the patch author just needs to find time to do the correction.

[Galtish]

<--pledges $2 paypal for a fix to this patch.

[daventx]

This is also a spelling mistake:

docviwer should be docviewer

[daventx]

If someone would like to get it updated on preware..

Here is the new one with the docviewer fix and the shift key fix:

OLD - http://thenxtlvl.com/pre/browser-multi-mod.patch

[Galtish]

Thanks! PM ur paypal addy, I'll send the funds when the patch hits preware.

[fritos1406]

Originally Posted by daventx

If someone would like to get it updated on preware..

Here is the new one with the docviewer fix and the shift key fix:

http://thenxtlvl.com/pre/browser-multi-mod.patch

just looked through the coding..should probably remodify it to be shorter

all this can be put together in to one like so just to be shorter u know..

if(appid === 'com.palm.app.email' || 'com.palm.app.docviewer' || 'com.palm.app.pdfviewer' || 'com.palm.app.maps' || 'com.palm.app.youtube' || 'com.palm.app.phone')
//a phone #, Google Map, docviewer, email, pdfviewer, or YouTube link was clicked, so we bypass the download dialog and open the app.
    var params = {target: uri, mimeType: mimeType};
    this.controller.serviceRequest('palm://com.palm.applicationManager',{
        method: 'open',
        parameters: {
            'id': appid,
            'params': params
        }}
    );
    return;
}

[egaudet]

Originally Posted by daventx

If someone would like to get it updated on preware..

Here is the new one with the docviewer fix and the shift key fix:

http://thenxtlvl.com/pre/browser-multi-mod.patch

While the shift is being fixed to use Mojo.Char.shift, I recommend using constants for the other key bindings as well.

[daventx]

Ok.. I'd really like a hand or some advice figuring out *** is the deal with patches. I've had this issue before and either I'm not grasping something.. or just missing something somewhere.

I follow the instructions for creating a patch here:
Applying Patches - WebOS Internals

But as soon as i try to push that patch, I always get errors about the HUNKS failing.

I understand what it means, i mount it as rw.. but why on earth is the patch failing if I just created it and I know the files are right?

I have this patch ready, with the fixes listed above.. but it fails. Same with other patches I've tried to make...

[egaudet]

Originally Posted by daventx

Ok.. I'd really like a hand or some advice figuring out *** is the deal with patches. I've had this issue before and either I'm not grasping something.. or just missing something somewhere.

I follow the instructions for creating a patch here:
Applying Patches - WebOS Internals

But as soon as i try to push that patch, I always get errors about the HUNKS failing.

I understand what it means, i mount it as rw.. but why on earth is the patch failing if I just created it and I know the files are right?

I have this patch ready, with the fixes listed above.. but it fails. Same with other patches I've tried to make...

Assuming you did the following:

started with fresh/clean files
quilt new <patch>
quilt add <file1>
quilt add <file2>
...
quilt refresh <patch>


You created that patch and now have modified files with that patch applied. quilt push of that patch will fail because the files are already patched.

I don't use quilt to create patches so I'm not positive, but does quilt pop unapply the patch after you create/update it with refresh?

[daventx]

Yeah, I had restored the original files to start new when I do the first push to try out the patch.

It's got to be something stupid... thanks for writing back though.

As far as everyone else... I'll have a new patch coming as soon as i figure it out.

[clintkoglin]

I keep running into an error when it tries to patch the sources.json file.. does anyone have a original sources.json file they can shoot me so I can get this to work?

Thanks!

[daventx]

Originally Posted by clintkoglin

I keep running into an error when it tries to patch the sources.json file.. does anyone have a original sources.json file they can shoot me so I can get this to work?

Thanks!

Here ya go.. if you are having issues with my last patch, it maybe my fault. But I'm planning on knocking out a new one tomorrow thats proper

[daventx]

Bleh. 3:47 am. Can't sleep



OLD - http://thenxtlvl.com/pre/browser-mul..._1.2.1-2.patch

tested and works

[clintkoglin]

Works beautifully Thanks!!!

[daventx]

Originally Posted by Galtish

Thanks! PM ur paypal addy, I'll send the funds when the patch hits preware.

Submitted to preware today. Should be up soon. Please donate to the wiki:
WebOS Internals:Site support - WebOS Internals

[Galtish]

Originally Posted by daventx

Submitted to preware today. Should be up soon. Please donate to the wiki:
WebOS Internals:Site support - WebOS Internals

Thanks for your work: Transaction ID: 09G25632GH907745L

Just a warning to others (who probably already know better), if installing this patch from WOSQI first uninstall the old browser patch, otherwise you get errors and it doesn't install correctly.

[egaudet]

Originally Posted by daventx

Bleh. 3:47 am. Can't sleep



http://thenxtlvl.com/pre/browser-mul..._1.2.1-2.patch

tested and works

Thank you for the updated keycodes and removing the code replications for each appid. Will be in preware shortly I believe dBsooner is working on it.

[Shadavis08]

when will preware be updated with this fix does anyone know

[daventx]

Not sure now about Preware, dBsooner mentioned in another post he had them all updated. But i've yet to see this one.

I PM'd him and am waiting for a reply to see whats up.